AI & Agent Dev Bug Sandbox Back to Radar

FilesystemClaudeTextEditorMiddleware Uses Locale Encoding Causing Unicode Errors And Data Corruption On Non-UTF-8 Systems

The filesystem middleware reads and writes files using the system's locale encoding instead of UTF-8. On Windows and other non-UTF-8 locales, non-ASCII content such as accents or CJK characters raises UnicodeEncodeError/UnicodeDecodeError or silently writes files in a non-UTF-8 encoding, breaking interoperability and causing tool call failures.

highConfidence 95%Langchain Affected V1.7.2

Origin Analysis

The middleware methods call `Path.read_text()` and `Path.write_text()` without specifying an encoding, so Python uses the locale's default encoding (e.g., cp1252, cp936, or US-ASCII) instead of UTF-8.

1. Set a non-UTF-8 locale (e.g., `LC_ALL=C LANG=C PYTHONCOERCECLOCALE=0 PYTHONUTF8=0` on Unix, or use a Windows cp1252/cp936 system). 2. Initialize `FilesystemClaudeTextEditorMiddleware` with a temporary root path. 3. Call `_handle_create` with file_text containing non-ASCII like "# Café ☕". 4. Observe UnicodeEncodeError. 5. Write a UTF-8 file to the root, then call `_handle_view`, `_handle_str_replace`, or `_handle_insert`; observe UnicodeDecodeError or ValueError.

Fixing Code Block

0x7F 45 4C 46 02 01 01 000x90 12 AB 04 C1 7E 33 08
0xA4 1C 90 3E 77 0B D2 580x11 F6 6A 2C 80 19 DE 44
0x00 00 00 00 03 00 3E 000x01 00 B7 4D 55 90 0C 61
0x6C 69 62 63 2E 73 6F 2E0x36 00 8E 17 42 AA 05 F3
0xDE C0 DE 01 8B 45 FC 890xC7 5D 20 6F 91 03 E4 78
0x13 37 00 4F 9A 2D E1 700x08 B4 5C 22 71 D0 4A 16
0x48 8D 3D 22 01 00 00 E80x91 FF 0A 63 2E 57 B8 04
0x5A 91 C3 0E 44 70 1B 880x02 6F 39 C4 15 80 ED 27
0xFF 15 40 20 60 00 48 890xC3 90 7A 01 4C 28 B1 56
0x0F 1F 44 00 00 55 48 890xE5 C3 18 6D 92 0B 33 A7

Edge Case Audit

The fix forces UTF-8 for all operations. Existing files written under a different locale encoding (e.g., cp1252) will now fail to decode or may be misread. Consider adding migration/detection logic or accepting an encoding parameter. If a global monkey patch to `Path.read_text`/`Path.write_text` is used instead of patching the middleware directly, it will affect unrelated code and may cause unexpected behavior; revert immediately if other modules rely on locale encoding. Also, on Windows, file handles may need to be closed properly to avoid locking; ensure writes are atomic if concurrency is a concern. Rollback: revert to the original methods (remove the `encoding` argument) or set `PYTHONUTF8=1` at runtime as a temporary workaround.