AI & Agent Dev Bug Sandbox Back to Radar

TypeSafeClassifier Sends Requests When Questions Is Empty

langchain-typesafe's TypeSafeClassifier does not validate that the 'questions' mapping is non-empty before making an HTTP request, causing invalid API calls and a regression from previous Pydantic-based validation.

highConfidence 90%LangChain Affected V0.0.1a3

Origin Analysis

ClassifierRequest is a TypedDict with no runtime validation; the previous Pydantic field min_length=1 constraint was removed when questions moved from constructor to invocation scope.

Create a TypeSafeClassifier with a mock HTTP transport. Invoke classifier with {"state": "...", "questions": {}}. Observe that the HTTP request is sent with an empty questions object, e.g., {'state': '...', 'model': '...', 'questions': {}}.

Fixing Code Block

0x7F 45 4C 46 02 01 01 000x90 12 AB 04 C1 7E 33 08
0xA4 1C 90 3E 77 0B D2 580x11 F6 6A 2C 80 19 DE 44
0x00 00 00 00 03 00 3E 000x01 00 B7 4D 55 90 0C 61
0x6C 69 62 63 2E 73 6F 2E0x36 00 8E 17 42 AA 05 F3
0xDE C0 DE 01 8B 45 FC 890xC7 5D 20 6F 91 03 E4 78
0x13 37 00 4F 9A 2D E1 700x08 B4 5C 22 71 D0 4A 16
0x48 8D 3D 22 01 00 00 E80x91 FF 0A 63 2E 57 B8 04
0x5A 91 C3 0E 44 70 1B 880x02 6F 39 C4 15 80 ED 27
0xFF 15 40 20 60 00 48 890xC3 90 7A 01 4C 28 B1 56
0x0F 1F 44 00 00 55 48 890xE5 C3 18 6D 92 0B 33 A7

Edge Case Audit

This validation only fires when invoke/ainvoke are called directly. If TypeSafeClassifier overrides batch/abatch with a custom implementation that bypasses invoke/ainvoke, empty questions may still be sent. Add the same check in any custom batch path. Also, performing validation after callbacks/tracing have started will create a failed traced run; to avoid that, call validation before `on_chain_start`. The change is backward-compatible for valid inputs and only rejects previously invalid empty mappings. Rollback: remove the added calls to `_validate_non_empty_questions`.